Re: [PATCH v2 3/3] difftool: handle modified symlinks in dir-diff mode

2017-03-15 Thread David Aguilar
On Wed, Mar 15, 2017 at 11:54:14AM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > @@ -397,7 +438,7 @@ static int run_dir_diff(const char *extcmd, int > > symlinks, const char *prefix, > > return error("could not write '%s'", src_path); > > } >

Re: [PATCH v2 3/3] difftool: handle modified symlinks in dir-diff mode

2017-03-15 Thread Junio C Hamano
David Aguilar writes: > Detect the null object ID for symlinks in dir-diff so that difftool can > detect when symlinks are modified in the worktree. > > Previously, a null symlink object ID would crash difftool. > Handle null object IDs as unknown content that must be read from > the worktree. >

[PATCH v2 3/3] difftool: handle modified symlinks in dir-diff mode

2017-03-15 Thread David Aguilar
Detect the null object ID for symlinks in dir-diff so that difftool can detect when symlinks are modified in the worktree. Previously, a null symlink object ID would crash difftool. Handle null object IDs as unknown content that must be read from the worktree. Helped-by: Johannes Schindelin Sign