Re: [PATCH v2 3/3] diffcore-pickaxe: respect --no-textconv

Simon Ruderich writes: > --- a/t/t4209-log-pickaxe.sh > +++ b/t/t4209-log-pickaxe.sh > @@ -116,4 +116,18 @@ test_expect_success 'log -S -i (nomatch)' ' > test_cmp expect actual > ' > > +test_expect_success 'log -S --textconv (missing textconv tool)' ' > + echo "* diff=test" >.gitattr

[PATCH v2 3/3] diffcore-pickaxe: respect --no-textconv

git log -S doesn't respect --no-textconv: $ echo '*.txt diff=wrong' > .gitattributes $ git -c diff.wrong.textconv='xxx' log --no-textconv -Sfoo error: cannot run xxx: No such file or directory fatal: unable to read files to diff Reported-by: Matthieu Moy Signed-off-by: Simon Rude