Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

2017-03-03 Thread Johannes Schindelin
Hi Peff, On Fri, 3 Mar 2017, Jeff King wrote: > On Fri, Mar 03, 2017 at 12:16:31PM +0100, Johannes Schindelin wrote: > > > > What is "dir"? I'm guessing this patch got reordered and it should > > > stay as cwd.buf? > > > > Oh drats. Usually I do a final `git rebase -x "make test" > > upstream/m

Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

2017-03-03 Thread Jeff King
On Fri, Mar 03, 2017 at 12:16:31PM +0100, Johannes Schindelin wrote: > > What is "dir"? I'm guessing this patch got reordered and it should stay > > as cwd.buf? > > Oh drats. Usually I do a final `git rebase -x "make test" upstream/master` > run before submitting, but I was really, really tired b

Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

2017-03-03 Thread Johannes Schindelin
Hi Peff, On Thu, 2 Mar 2017, Jeff King wrote: > On Fri, Mar 03, 2017 at 03:04:07AM +0100, Johannes Schindelin wrote: > > > It is okay in practice to test for forward slashes in the output of > > getcwd(), because we go out of our way to convert backslashes to > > forward slashes in getcwd()'s ou

Re: [PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

2017-03-02 Thread Jeff King
On Fri, Mar 03, 2017 at 03:04:07AM +0100, Johannes Schindelin wrote: > It is okay in practice to test for forward slashes in the output of > getcwd(), because we go out of our way to convert backslashes to forward > slashes in getcwd()'s output on Windows. > > Still, the correct way to test for a

[PATCH v2 2/9] setup_git_directory(): use is_dir_sep() helper

2017-03-02 Thread Johannes Schindelin
It is okay in practice to test for forward slashes in the output of getcwd(), because we go out of our way to convert backslashes to forward slashes in getcwd()'s output on Windows. Still, the correct way to test for a dir separator is by using the helper function we introduced for that very purpo