Re: [PATCH v2 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-29 Thread SZEDER Gábor
On Mon, Jan 28, 2019 at 08:42:23AM -0800, Stefan Xenos wrote: > Is there a linter script I can run to check for such formatting issues? Not that I know of, I just happened to notice it while looking into Coccinelle's suggestion about using oideq().

Re: [PATCH v2 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-28 Thread SZEDER Gábor
On Sun, Jan 27, 2019 at 11:41:22AM -0800, sxe...@google.com wrote: > From: Stefan Xenos > > Implement a "readonly_contains" function for oid_array that won't > sort the array if it is unsorted. This can be used to test containment in > the rare situations where the array order matters. > > The f

[PATCH v2 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-27 Thread sxenos
From: Stefan Xenos Implement a "readonly_contains" function for oid_array that won't sort the array if it is unsorted. This can be used to test containment in the rare situations where the array order matters. The function has intentionally been given a name that is more cumbersome than the "loo