Re: [PATCH v2 2/4] Add structure representing hash algorithm

2017-10-31 Thread brian m. carlson
On Mon, Oct 30, 2017 at 04:36:15PM -0700, Brandon Williams wrote: > On 10/28, brian m. carlson wrote: > > Since in the future we want to support an additional hash algorithm, add > > a structure that represents a hash algorithm and all the data that must > > go along with it. Add a constant to all

Re: [PATCH v2 2/4] Add structure representing hash algorithm

2017-10-30 Thread Brandon Williams
On 10/28, brian m. carlson wrote: > Since in the future we want to support an additional hash algorithm, add > a structure that represents a hash algorithm and all the data that must > go along with it. Add a constant to allow easy enumeration of hash > algorithms. Implement function typedefs to

Re: [PATCH v2 2/4] Add structure representing hash algorithm

2017-10-30 Thread Stefan Beller
On Sat, Oct 28, 2017 at 11:12 AM, brian m. carlson wrote: > Since in the future we want to support an additional hash algorithm, add > a structure that represents a hash algorithm and all the data that must > go along with it. Add a constant to allow easy enumeration of hash > algorithms. Implem

Re: [PATCH v2 2/4] Add structure representing hash algorithm

2017-10-29 Thread brian m. carlson
On Sat, Oct 28, 2017 at 09:36:05PM -0400, Eric Sunshine wrote: > On Sat, Oct 28, 2017 at 2:12 PM, brian m. carlson > wrote: > > diff --git a/sha1_file.c b/sha1_file.c > > @@ -39,6 +39,49 @@ const struct object_id empty_blob_oid = { > > +static inline void git_hash_sha1_init(void *ctx) > > +{ > > +

Re: [PATCH v2 2/4] Add structure representing hash algorithm

2017-10-28 Thread Eric Sunshine
On Sat, Oct 28, 2017 at 2:12 PM, brian m. carlson wrote: > Since in the future we want to support an additional hash algorithm, add > a structure that represents a hash algorithm and all the data that must > go along with it. Add a constant to allow easy enumeration of hash > algorithms. Impleme

[PATCH v2 2/4] Add structure representing hash algorithm

2017-10-28 Thread brian m. carlson
Since in the future we want to support an additional hash algorithm, add a structure that represents a hash algorithm and all the data that must go along with it. Add a constant to allow easy enumeration of hash algorithms. Implement function typedefs to create an abstract API that can be used by