Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-25 Thread Felipe Contreras
Max Horn wrote: > I am going to step away from this painful discussion and also this mailing > list, but I owed it to send one last reply with two of the problems I am > still seeing, simply in the hope that this will benefit some future > git-remote-hg users, but also to dispel any claims I was "h

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-25 Thread Max Horn
Hi, I am going to step away from this painful discussion and also this mailing list, but I owed it to send one last reply with two of the problems I am still seeing, simply in the hope that this will benefit some future git-remote-hg users, but also to dispel any claims I was "hoarding" bugs to so

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Felipe Contreras
Max Horn wrote: > On 23.04.2014, at 22:54, Felipe Contreras wrote: > > Max Horn wrote: > >> On 21.04.2014, at 22:37, Felipe Contreras > >> wrote: > >> > >>> The remote-helpers in contrib/remote-helpers have proved to work, be > >>> reliable, and stable. It's time to move them out of contrib, an

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Max Horn
On 23.04.2014, at 22:54, Felipe Contreras wrote: > Max Horn wrote: >> On 21.04.2014, at 22:37, Felipe Contreras wrote: >> >>> The remote-helpers in contrib/remote-helpers have proved to work, be >>> reliable, and stable. It's time to move them out of contrib, and be >>> distributed by default.

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Junio C Hamano
Felipe Contreras writes: > The very unlikely issue that nobody has reported about hg multiple heads and > gc > I just fixed, and the issue he just reported about 'foo' and 'foo/bar' is > newly > reported, and there's no easy way to fix this. I would not judge on likelyhood, but I would say tha

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Felipe Contreras
Junio C Hamano wrote: > Max Horn writes: > > > Perhaps it is OK to move an undocumented remote-helper > > with known bugs out of contrib. > > We should strive to apply the same criteria as new submission to the > main part of the system. And inputs from people like you who have > more experienc

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Felipe Contreras
Max Horn wrote: > On 21.04.2014, at 22:37, Felipe Contreras wrote: > > > The remote-helpers in contrib/remote-helpers have proved to work, be > > reliable, and stable. It's time to move them out of contrib, and be > > distributed by default. > > Really? While I agree that git-remote-hg by now wo

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Junio C Hamano
Max Horn writes: [Administrivia: please wrap your lines to reasonable length like 70-75]. > On 21.04.2014, at 22:37, Felipe Contreras > wrote: > >> The remote-helpers in contrib/remote-helpers have proved to work, be >> reliable, and stable. It's time to move them out of contrib, and be >> dist

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Junio C Hamano
Max Horn writes: > That said, I don't know what the criteria are for moving something out > of contrib. Because we accept stuff to contrib/, with an assumption that it is to stay there without contaminating the main part of the system, the quality of stuff in contrib/ can be sub-par and it is ve

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-23 Thread Max Horn
On 21.04.2014, at 22:37, Felipe Contreras wrote: > The remote-helpers in contrib/remote-helpers have proved to work, be > reliable, and stable. It's time to move them out of contrib, and be > distributed by default. Really? While I agree that git-remote-hg by now works quite well for basic usa

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-21 Thread Junio C Hamano
Felipe Contreras writes: >> Does this change relate to the moving of main scripts, and if so >> how? > > Yes. > > Before the scripts were not generated, the shebang was '/usr/bin/env python', > that means if the user doesn't have 'python' but 'python2' git-remote-hg would > fail, even if the user

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-21 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > contrib/remote-helpers/test-bzr.sh | 2 +- > > contrib/remote-helpers/test-hg-bidi.sh | 2 +- > > contrib/remote-helpers/test-hg-hg-git.sh | 4 ++-- > > contrib/remote-helpers/tes

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-21 Thread Junio C Hamano
Felipe Contreras writes: > contrib/remote-helpers/test-bzr.sh | 2 +- > contrib/remote-helpers/test-hg-bidi.sh | 2 +- > contrib/remote-helpers/test-hg-hg-git.sh | 4 ++-- > contrib/remote-helpers/test-hg.sh |

[PATCH v2 2/3] remote-helpers: move out of contrib

2014-04-21 Thread Felipe Contreras
The remote-helpers in contrib/remote-helpers have proved to work, be reliable, and stable. It's time to move them out of contrib, and be distributed by default. Signed-off-by: Felipe Contreras --- .gitignore | 2 ++ Makefile