Re: [PATCH v2 2/3] fetch: refactor ref update status formatting code

2016-06-03 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This makes it easier to change the formatting later. And it makes sure > translators cannot mess up format specifiers and break Git. > ... > +static void format_display(struct strbuf *display, char code, > +const char *summary, const char *e

[PATCH v2 2/3] fetch: refactor ref update status formatting code

2016-06-03 Thread Nguyễn Thái Ngọc Duy
This makes it easier to change the formatting later. And it makes sure translators cannot mess up format specifiers and break Git. There are a couple call sites where the length of the second column is TRANSPORT_SUMMARY_WIDTH instead of calculated by TRANSPORT_SUMMARY(), which is enforced now. The