Re: [PATCH v2 2/3] count-objects: report garbage files in pack directory too

2013-02-08 Thread Duy Nguyen
On Sat, Feb 9, 2013 at 1:44 AM, Junio C Hamano wrote: >> +static void real_report_pack_garbage(const char *path, int len, const char >> *name) >> +{ > > Don't some callers call this on paths outside objects/pack/ > directory? Is it still report-pack-garbage? In fact 3/3 uses it to report loose

Re: [PATCH v2 2/3] count-objects: report garbage files in pack directory too

2013-02-08 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > prepare_packed_git_one() is modified to allow count-objects to hook a > report function to so we don't need to duplicate the pack searching > logic in count-objects.c. When report_pack_garbage is NULL, the > overhead is insignificant. > > Signed-off-by: Nguyễn Thái

[PATCH v2 2/3] count-objects: report garbage files in pack directory too

2013-02-07 Thread Nguyễn Thái Ngọc Duy
prepare_packed_git_one() is modified to allow count-objects to hook a report function to so we don't need to duplicate the pack searching logic in count-objects.c. When report_pack_garbage is NULL, the overhead is insignificant. Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/git-count-obj