Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-02-01 Thread Barret Rhoden
On 2019-01-23 at 11:26 Junio C Hamano wrote: > Yeah, and if the original had two adjacent lines, and replacement > has three adjacent lines, the algorithm would not even know if > > - the first line in the original was split into first two in the >update and the second line was modified in

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-23 Thread Junio C Hamano
Barret Rhoden writes: >> So... I dunno. > > I guess if you swap the lines as well as change them,... > ... Then it won't have the semantic knowledge that "one" == "1". If a user > is ignoring a commit, we don't have an oracle that knows exactly what > that commit did to determine what commit the

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-22 Thread Barret Rhoden
On 2019-01-22 at 10:14 Junio C Hamano wrote: > René Scharfe writes: > > > Am 17.01.2019 um 21:29 schrieb Barret Rhoden: > >> The blame_entry will get passed up the tree until we find a commit that > >> has a diff chunk that affects those lines. If an ignored commit added > >> more lines than

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-22 Thread Junio C Hamano
René Scharfe writes: > Am 17.01.2019 um 21:29 schrieb Barret Rhoden: >> The blame_entry will get passed up the tree until we find a commit that >> has a diff chunk that affects those lines. If an ignored commit added >> more lines than it removed, the blame will fall on a commit that made a >> c

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-22 Thread Barret Rhoden
On 2019-01-20 at 19:19 René Scharfe wrote: > Am 17.01.2019 um 21:29 schrieb Barret Rhoden: > > The blame_entry will get passed up the tree until we find a commit that > > has a diff chunk that affects those lines. If an ignored commit added > > more lines than it removed, the blame will fall on a

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-20 Thread René Scharfe
Am 17.01.2019 um 21:29 schrieb Barret Rhoden: > The blame_entry will get passed up the tree until we find a commit that > has a diff chunk that affects those lines. If an ignored commit added > more lines than it removed, the blame will fall on a commit that made a > change nearby. There is no ge

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-18 Thread Barret Rhoden
On 2019-01-18 at 10:47 Johannes Schindelin wrote: > ... and this change limit the user to specifying a single file, for no > good reason. Worse: specifying two different files via two > `--ignore-revs-file` parameters will only heed the latter and skip the > former without any warning. > > A bett

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-18 Thread Johannes Schindelin
Hi Barret, On Thu, 17 Jan 2019, Barret Rhoden wrote: > [...] > > Users can ignore a revision with --ignore-rev=rev, which may be > repeated. They can specify a file of full SHA-1 hashes of revs (one per > line) with the blame.ignoreRevFile config option. They can also specify > a file with --i

[PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-17 Thread Barret Rhoden
Commits that make formatting changes or function renames are often not interesting when blaming a file. A user may deem such a commit as 'not interesting' and want to ignore and its changes it when assigning blame. For example, say a file has the following git history / rev-list: ---O---A---X---