Re: [PATCH v2 2/2] perf-lib.sh: remove GIT_TEST_INSTALLED from perf-lib.sh

2019-05-07 Thread Jeff King
On Tue, May 07, 2019 at 10:31:23AM +0200, Ævar Arnfjörð Bjarmason wrote: > > I'm not sure I get what's going on here. Why do we need the realpath in > > aggregate.perl? We'd want to generate the same filename that "run" > > decided to store things in, which we'd generate from the command-line > >

Re: [PATCH v2 2/2] perf-lib.sh: remove GIT_TEST_INSTALLED from perf-lib.sh

2019-05-07 Thread Ævar Arnfjörð Bjarmason
On Tue, May 07 2019, Jeff King wrote: > On Tue, May 07, 2019 at 01:23:09AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> @@ -79,7 +95,16 @@ run_dirs_helper () { >> if test $# -gt 0 -a "$1" = --; then >> shift >> fi >> -if [ ! -d "$mydir" ]; then >> + >> +PERF_RESULTS_

Re: [PATCH v2 2/2] perf-lib.sh: remove GIT_TEST_INSTALLED from perf-lib.sh

2019-05-07 Thread Jeff King
On Tue, May 07, 2019 at 01:23:09AM +0200, Ævar Arnfjörð Bjarmason wrote: > @@ -79,7 +95,16 @@ run_dirs_helper () { > if test $# -gt 0 -a "$1" = --; then > shift > fi > - if [ ! -d "$mydir" ]; then > + > + PERF_RESULTS_PREFIX= > + if test "$mydir" = "." > +

[PATCH v2 2/2] perf-lib.sh: remove GIT_TEST_INSTALLED from perf-lib.sh

2019-05-06 Thread Ævar Arnfjörð Bjarmason
Follow-up my preceding change which fixed the immediate "./run " regression in 0baf78e7bc ("perf-lib.sh: rely on test-lib.sh for --tee handling", 2019-03-15) and entirely get rid of GIT_TEST_INSTALLED from perf-lib.sh (and aggregate.perl). As noted in that change the dance we're doing with GIT_TES