Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

2017-11-14 Thread Junio C Hamano
Johannes Schindelin writes: I notice that I left a few things unanswered even after giving answers to the most important part (i.e. "what is this for was sold incorrectly"). Here are the leftover bits. >> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt >> index 89cc

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

2017-11-07 Thread Junio C Hamano
Junio C Hamano writes: > These "--ignore-*" whitespace options are to help reviewing _other_ > changes without getting distracted by the class of changes these > options represent. I guess I may have to update the log message (I > do not think I wrote anything like that in the documentation upda

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

2017-11-07 Thread Junio C Hamano
Johannes Schindelin writes: > On Tue, 7 Nov 2017, Junio C Hamano wrote: > >> A new option --ignore-cr-at-eol tells the diff machinery to treat a >> carriage-return at the end of a (complete) line as if it does not >> exist. >> >> This would make it easier to review a change whose only effect is

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

2017-11-07 Thread Johannes Schindelin
Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > A new option --ignore-cr-at-eol tells the diff machinery to treat a > carriage-return at the end of a (complete) line as if it does not > exist. > > This would make it easier to review a change whose only effect is to > turn line endings from

[PATCH v2 2/2] diff: --ignore-cr-at-eol

2017-11-06 Thread Junio C Hamano
A new option --ignore-cr-at-eol tells the diff machinery to treat a carriage-return at the end of a (complete) line as if it does not exist. This would make it easier to review a change whose only effect is to turn line endings from CRLF to LF or the other way around. Signed-off-by: Junio C Haman