Re: [PATCH v2 15/20] msvc: support building Git using MS Visual C++

2019-06-21 Thread Junio C Hamano
Johannes Schindelin writes: >> ifdef SANE_TOOL_PATH >> SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH)) >> -BROKEN_PATH_FIX = 's|^\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix >> "$(SANE_TOOL_PATH_SQ)"|' >> +BROKEN_PATH_FIX = 's|^\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix >> $(SANE_TOOL

Re: [PATCH v2 15/20] msvc: support building Git using MS Visual C++

2019-06-21 Thread Johannes Schindelin
Hi, On Wed, 19 Jun 2019, Jeff Hostetler via GitGitGadget wrote: > diff --git a/Makefile b/Makefile > index 3cf8cc8ffd..2b66d5a3f3 100644 > --- a/Makefile > +++ b/Makefile > @@ -1240,7 +1240,7 @@ endif > > ifdef SANE_TOOL_PATH > SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH)) > -BROKEN_PAT

[PATCH v2 15/20] msvc: support building Git using MS Visual C++

2019-06-19 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler With this patch, Git can be built using the Microsoft toolchain, via: make MSVC=1 [DEBUG=1] Third party libraries are built from source using the open source "vcpkg" tool set. See https://github.com/Microsoft/vcpkg On a first build, the vcpkg tools and the third pa