Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-11 Thread Junio C Hamano
Stefan Beller writes: >> I do not see how it would work without further splitting the >> attr_stack. I think you made it per check[], but you would further >> split it per before losing the mutex, no? > > Well I have not yet looked into it again, so my memories are > rusty, but the is read onl

Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-11 Thread Stefan Beller
On Sat, Dec 10, 2016 at 10:18 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> Jonathan Nieder mentioned off list that he prefers to see that >> series rerolled without mutexes if possible. That is possible by >> creating the questions "struct attr_check" before preloading the >> index and

Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-10 Thread Junio C Hamano
Stefan Beller writes: > Jonathan Nieder mentioned off list that he prefers to see that > series rerolled without mutexes if possible. That is possible by > creating the questions "struct attr_check" before preloading the > index and then using the read only questions in the threaded code, > to ob

Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-09 Thread Brandon Williams
On 12/09, Stefan Beller wrote: > On Fri, Dec 9, 2016 at 3:44 PM, Junio C Hamano wrote: > > Brandon Williams writes: > > > >> Factor out the logic responsible for parsing long magic into its own > >> function. As well as hoist the prefix check logic outside of the inner > >> loop as there isn't a

Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-09 Thread Stefan Beller
On Fri, Dec 9, 2016 at 3:44 PM, Junio C Hamano wrote: > Brandon Williams writes: > >> Factor out the logic responsible for parsing long magic into its own >> function. As well as hoist the prefix check logic outside of the inner >> loop as there isn't anything that needs to be done after matchin

Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-09 Thread Junio C Hamano
Brandon Williams writes: > Factor out the logic responsible for parsing long magic into its own > function. As well as hoist the prefix check logic outside of the inner > loop as there isn't anything that needs to be done after matching > "prefix:". > > Signed-off-by: Brandon Williams These re

[PATCH v2 12/16] pathspec: create parse_long_magic function

2016-12-08 Thread Brandon Williams
Factor out the logic responsible for parsing long magic into its own function. As well as hoist the prefix check logic outside of the inner loop as there isn't anything that needs to be done after matching "prefix:". Signed-off-by: Brandon Williams --- pathspec.c | 92 ++