Re: [PATCH v2 11/14] t/t5505-remote: test multiple push/pull in remotes-file

2013-06-23 Thread Junio C Hamano
Ramkumar Ramachandra writes: > I disagree. It is trivial to prove that the tests in t/remote will > break if this fringe feature breaks: I don't know where "we will never > know when we break them" is coming from. If you remove tests that configure the remotes via the .git/branches and the .g

Re: [PATCH v2 11/14] t/t5505-remote: test multiple push/pull in remotes-file

2013-06-23 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > I'll reject 04/14 and tweak this patch to use 'next' for the new ref > mappings, not duplicated 'master'. It's a matter of taste: I don't like "realistic" (albeit misleading) values when I'm testing configuration variables, while you think they make the tests more readable.

Re: [PATCH v2 11/14] t/t5505-remote: test multiple push/pull in remotes-file

2013-06-23 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Extend the test "migrate a remote from named file in $GIT_DIR/remotes" > to test that multiple "Push:" and "Pull:" lines in the remotes-file > works as expected. > > Signed-off-by: Ramkumar Ramachandra > --- > t/t5505-remote.sh | 16 ++-- > 1 file chan

[PATCH v2 11/14] t/t5505-remote: test multiple push/pull in remotes-file

2013-06-22 Thread Ramkumar Ramachandra
Extend the test "migrate a remote from named file in $GIT_DIR/remotes" to test that multiple "Push:" and "Pull:" lines in the remotes-file works as expected. Signed-off-by: Ramkumar Ramachandra --- t/t5505-remote.sh | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --