Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-30 Thread Jeff King
On Sat, Oct 26, 2013 at 05:14:16PM +0700, Nguyen Thai Ngoc Duy wrote: > If it's not mentioned yet, maybe you should note that this code > currently supports only one pack with .bitmap file. Yes, there's really not any point in having multiple .bitmap files, as the bitmaps need to be closed over t

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-30 Thread Jeff King
On Mon, Oct 28, 2013 at 08:22:07AM -0700, Junio C Hamano wrote: > > However, the code in the ewah/ directory has been hacked up a bit > > from its original, and ewah_io.c _does_ include "git-compat-util.h". > > So it may make sense to consider our copy a fork and git-ify it > > mor

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-28 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 25, 2013 at 08:26:29PM -0400, Jeff King wrote: > >> On Fri, Oct 25, 2013 at 04:06:19PM -0700, Junio C Hamano wrote: >> >> > Jeff King writes: >> > >> > > diff --git a/pack-bitmap.c b/pack-bitmap.c >> > > new file mode 100644 >> > > index 000..73c52fd >> > >

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-26 Thread Duy Nguyen
If it's not mentioned yet, maybe you should note that this code currently supports only one pack with .bitmap file. On Fri, Oct 25, 2013 at 1:03 PM, Jeff King wrote: > diff --git a/khash.h b/khash.h > new file mode 100644 > index 000..0fdf39d > --- /dev/null > +++ b/khash.h > @@ -0,0 +1,342 @

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-25 Thread Jeff King
On Fri, Oct 25, 2013 at 08:26:29PM -0400, Jeff King wrote: > On Fri, Oct 25, 2013 at 04:06:19PM -0700, Junio C Hamano wrote: > > > Jeff King writes: > > > > > diff --git a/pack-bitmap.c b/pack-bitmap.c > > > new file mode 100644 > > > index 000..73c52fd > > > --- /dev/null > > > +++ b/pack-

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-25 Thread Jeff King
On Fri, Oct 25, 2013 at 04:06:19PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > diff --git a/pack-bitmap.c b/pack-bitmap.c > > new file mode 100644 > > index 000..73c52fd > > --- /dev/null > > +++ b/pack-bitmap.c > > @@ -0,0 +1,965 @@ > > +#include > > + > > +#include "cache.h" >

Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-25 Thread Junio C Hamano
Jeff King writes: > diff --git a/pack-bitmap.c b/pack-bitmap.c > new file mode 100644 > index 000..73c52fd > --- /dev/null > +++ b/pack-bitmap.c > @@ -0,0 +1,965 @@ > +#include > + > +#include "cache.h" You among all people already know why this is bad, no? I'll remove the first two lines

[PATCH v2 10/19] pack-bitmap: add support for bitmap indexes

2013-10-24 Thread Jeff King
From: Vicent Marti A bitmap index is a `.bitmap` file that can be found inside `$GIT_DIR/objects/pack/`, next to its corresponding packfile, and contains precalculated reachability information for selected commits. The full specification of the format for these bitmap indexes can be found in `Doc