Re: [PATCH v2 1/9] rebase -i: generate the script via rebase--helper

Hi Peff, On Wed, 26 Apr 2017, Jeff King wrote: > On Tue, Apr 25, 2017 at 03:51:49PM +0200, Johannes Schindelin wrote: > > > --- a/sequencer.c > > +++ b/sequencer.c > > [...] > > +int sequencer_make_script(int keep_empty, FILE *out, > > + int argc, const char **argv) > > +{ > > + char

Re: [PATCH v2 1/9] rebase -i: generate the script via rebase--helper

On Tue, Apr 25, 2017 at 03:51:49PM +0200, Johannes Schindelin wrote: > --- a/sequencer.c > +++ b/sequencer.c > [...] > +int sequencer_make_script(int keep_empty, FILE *out, > + int argc, const char **argv) > +{ > + char *format = "%s"; I'm surprised the compiler doesn't complain a

[PATCH v2 1/9] rebase -i: generate the script via rebase--helper

The first step of an interactive rebase is to generate the so-called "todo script", to be stored in the state directory as "git-rebase-todo" and to be edited by the user. Originally, we adjusted the output of `git log ` using a simple sed script. Over the course of the years, the code became more