Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-22 Thread Jeremy Rosen
> > > > Would it make sense to integrate this in git shortlog, which > > already > > does something similar? > > Conceptually, yes, but the end result will be much larger in scope. > I am not sure if "shortlog" is still a good label for it. > since we are throwing ideas around... The first plac

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-20 Thread Junio C Hamano
Johannes Sixt writes: >> But I think it can be useful outside the context of send-email as >> well, and having one independent tool that does one single job well >> is a better design. Perhaps it is better to name it less specific >> to send-email's cc-cmd option. "git people"? "git whom"? "g

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Junio C Hamano
Felipe Contreras writes: >>> +File.open(file) do |f| >>> + f.each do |line| >>> +case line >>> +when /^From (\h+) (.+)$/ >>> + from = $1 >>> +when /^---\s+(\S+)/ >>> + source = $1 != '/dev/null' ? $1[2..-1] : nil >> >> This may need to be tighten

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Johannes Sixt
Am 19.04.2013 21:24, schrieb Junio C Hamano: > Felipe Contreras writes: > >> On Fri, Apr 19, 2013 at 12:08 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: The code finds the changes of a commit, runs 'git blame' for each chunk to see which other commits are relevant, and then r

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Junio C Hamano
Felipe Contreras writes: >> If this were _only_ to be used within send-email (i.e. replacing the >> "then send it out" above with "then use send-email" to limit the >> usecase), "git cc-cmd" would be a reasonable name. But if that is >> the intended use case, it would even be more reasonable to

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Felipe Contreras
On Fri, Apr 19, 2013 at 2:24 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Fri, Apr 19, 2013 at 12:08 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: The code finds the changes of a commit, runs 'git blame' for each chunk to see which other commits are relevant,

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Junio C Hamano
Felipe Contreras writes: > On Fri, Apr 19, 2013 at 12:08 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >>> The code finds the changes of a commit, runs 'git blame' for each chunk >>> to see which other commits are relevant, and then reports the author and >>> signers. >> >> In general,

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Felipe Contreras
On Fri, Apr 19, 2013 at 12:08 PM, Junio C Hamano wrote: > Felipe Contreras writes: >> The code finds the changes of a commit, runs 'git blame' for each chunk >> to see which other commits are relevant, and then reports the author and >> signers. > > In general, I am not all that interested in add

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Junio C Hamano
Felipe Contreras writes: > The code finds the changes of a commit, runs 'git blame' for each chunk > to see which other commits are relevant, and then reports the author and > signers. In general, I am not all that interested in adding anything new to contrib/ as git.git has matured enough, but e

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Felipe Contreras
On Fri, Apr 19, 2013 at 8:26 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> The code finds the changes of a commit, runs 'git blame' for each chunk >> to see which other commits are relevant, and then reports the author and >> signers. >> >> Finally, it calculates what percentage of

Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-19 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > The code finds the changes of a commit, runs 'git blame' for each chunk > to see which other commits are relevant, and then reports the author and > signers. > > Finally, it calculates what percentage of the total relevant commits > each person was involved in, and show on

[PATCH v2 1/8] Add new git-cc-cmd helper to contrib

2013-04-18 Thread Felipe Contreras
The code finds the changes of a commit, runs 'git blame' for each chunk to see which other commits are relevant, and then reports the author and signers. Finally, it calculates what percentage of the total relevant commits each person was involved in, and show only the ones that pass the threshold