Re: [PATCH v2 1/7] path.c: implement xdg_config_home()

2015-04-19 Thread Eric Sunshine
On Sat, Apr 18, 2015 at 3:51 AM, Paul Tan wrote: > On Fri, Apr 17, 2015 at 5:41 AM, Eric Sunshine > wrote: >> On Tue, Apr 14, 2015 at 1:28 PM, Paul Tan wrote: >>> + * Returns the newly allocated string "$XDG_CONFIG_HOME/git/{filename}". >>> If >>> + * $XDG_CONFIG_HOME is unset or empty, retur

Re: [PATCH v2 1/7] path.c: implement xdg_config_home()

2015-04-18 Thread Paul Tan
Hi, On Fri, Apr 17, 2015 at 5:41 AM, Eric Sunshine wrote: > On Tue, Apr 14, 2015 at 1:28 PM, Paul Tan wrote: >> Below is the fixed patch. I also decided to return NULL if `filename` is >> NULL because such an input usually indicated an uncaught error. > > Unfortunately, this blurs the line betwe

Re: [PATCH v2 1/7] path.c: implement xdg_config_home()

2015-04-18 Thread Paul Tan
Hi, On Fri, Apr 17, 2015 at 5:41 AM, Eric Sunshine wrote: > On Tue, Apr 14, 2015 at 1:28 PM, Paul Tan wrote: >> Below is the fixed patch. I also decided to return NULL if `filename` is >> NULL because such an input usually indicated an uncaught error. > > Unfortunately, this blurs the line betwe

Re: [PATCH v2 1/7] path.c: implement xdg_config_home()

2015-04-16 Thread Eric Sunshine
On Tue, Apr 14, 2015 at 1:28 PM, Paul Tan wrote: > Below is the fixed patch. I also decided to return NULL if `filename` is > NULL because such an input usually indicated an uncaught error. Unfortunately, this blurs the line between programmer error (passing NULL for filename) and a user/configur

[PATCH v2 1/7] path.c: implement xdg_config_home()

2015-04-14 Thread Paul Tan
Hi, On Mon, Apr 13, 2015 at 05:50:49PM +0200, Johannes Schindelin wrote: > maybe it would be a good idea to add a `0/7` mail that describes the > overall goal of this patch series, much like a Pull Request? I found > it very useful -- even for myself -- to set a description via `git > branch --edi