On Mon, Jul 01, 2019 at 03:28:45PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > - replace eval formatting magic with "%s" printf formatters (safer and
> > gets rid of quoting issues in the callers).
>
> This one actually made me think twice about safety, as we'd be using
> end-u
On Mon, Jul 01, 2019 at 03:24:35PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Here's a re-roll of just the first patch of this series, since that was
> > the one that got all the comments (and the others are textually
> > independent).
>
> OK, will replace and then queue an adjustme
Jeff King writes:
> - replace eval formatting magic with "%s" printf formatters (safer and
> gets rid of quoting issues in the callers).
This one actually made me think twice about safety, as we'd be using
end-user supplied formatting string without any inspection. I think
it is fine as i
Jeff King writes:
> Here's a re-roll of just the first patch of this series, since that was
> the one that got all the comments (and the others are textually
> independent).
OK, will replace and then queue an adjustment for 6200 which used to
use \$n but now must use %s instead. Let's see if pe
Here's a re-roll of just the first patch of this series, since that was
the one that got all the comments (and the others are textually
independent).
The changes are:
- drop the leftover in_dir assignment
- replace ${indir:+} magic with defaulting indir=. (so we always pass
it to "-C"
5 matches
Mail list logo
