Re: [PATCH v2 1/6] commit-graph: refactor preparing commit graph

2018-07-09 Thread Derrick Stolee
On 7/9/2018 5:41 PM, Stefan Beller wrote: Hi Jonathan, On Mon, Jul 9, 2018 at 1:44 PM Jonathan Tan wrote: Two functions in the code (1) check if the repository is configured for commit graphs, (2) call prepare_commit_graph(), and (3) check if the graph exists. Move (1) and (3) into prepare_comm

Re: [PATCH v2 1/6] commit-graph: refactor preparing commit graph

2018-07-09 Thread Stefan Beller
Hi Jonathan, On Mon, Jul 9, 2018 at 1:44 PM Jonathan Tan wrote: > > Two functions in the code (1) check if the repository is configured for > commit graphs, (2) call prepare_commit_graph(), and (3) check if the > graph exists. Move (1) and (3) into prepare_commit_graph(), reducing > duplication of

[PATCH v2 1/6] commit-graph: refactor preparing commit graph

2018-07-09 Thread Jonathan Tan
Two functions in the code (1) check if the repository is configured for commit graphs, (2) call prepare_commit_graph(), and (3) check if the graph exists. Move (1) and (3) into prepare_commit_graph(), reducing duplication of code. Signed-off-by: Jonathan Tan --- commit-graph.c | 28 +