Re: [PATCH v2 1/4] wt-status: split wt_status_state parsing function out

2013-03-06 Thread Junio C Hamano
Junio C Hamano writes: > In other words, with the new world order, wouldn't a saner function > signature be: > > static const char *read_and_strip_branch(const char **path); Eh, discard an asterisk from there. "Given a string to name the file, read it to find the branch name recorded in i

Re: [PATCH v2 1/4] wt-status: split wt_status_state parsing function out

2013-03-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > wt-status.c | 52 +++- > wt-status.h | 5 +++-- > 2 files changed, 34 insertions(+), 23 deletions(-) > > diff --git a/wt-status.c b/wt-status.c > index ef405d0..183aafe 1

[PATCH v2 1/4] wt-status: split wt_status_state parsing function out

2013-03-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- wt-status.c | 52 +++- wt-status.h | 5 +++-- 2 files changed, 34 insertions(+), 23 deletions(-) diff --git a/wt-status.c b/wt-status.c index ef405d0..183aafe 100644 --- a/wt-status.c +++ b/wt-status.c @@ -