Re: [PATCH v2 1/4] progress: make display_progress() return void

2019-04-01 Thread Eric Sunshine
On Mon, Apr 1, 2019 at 7:52 AM SZEDER Gábor wrote: > [...] > Let's make display_progress() return void, too. > > Signed-off-by: SZEDER Gábor > --- > diff --git a/progress.c b/progress.c > @@ -78,12 +78,12 @@ static int is_foreground_fd(int fd) > -static int display(struct progress *progress, uint

[PATCH v2 1/4] progress: make display_progress() return void

2019-04-01 Thread SZEDER Gábor
Ever since the progress infrastructure was introduced in 96a02f8f6d (common progress display support, 2007-04-18), display_progress() has returned an int, telling callers whether it updated the progress bar or not. However, this is: - useless, because over the last dozen years there has never b