Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-10 Thread Duy Nguyen
On Fri, Feb 9, 2018 at 7:08 PM, Duy Nguyen wrote: > On Fri, Feb 9, 2018 at 6:27 PM, Thomas Gummerer wrote: >> This would loose the information about the identifier of the worktree, >> but from a coarse look at the man page it doesn't seem like we >> advertise that widely >> >> ... >> >> So given

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-09 Thread Duy Nguyen
On Fri, Feb 9, 2018 at 6:27 PM, Thomas Gummerer wrote: > This would loose the information about the identifier of the worktree, > but from a coarse look at the man page it doesn't seem like we > advertise that widely > > ... > > So given that maybe it would even be better to hide the part about th

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-09 Thread Thomas Gummerer
On 02/07, Eric Sunshine wrote: > On Sun, Feb 4, 2018 at 9:12 PM, Duy Nguyen wrote: > > As a former translator, I'm not thrilled to see a sentence broken into > > two pieces like this. I'm not a Japanese translator, but I think this > > sentence is translated differently when the translator sees th

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-07 Thread Eric Sunshine
On Sun, Feb 4, 2018 at 9:12 PM, Duy Nguyen wrote: > As a former translator, I'm not thrilled to see a sentence broken into > two pieces like this. I'm not a Japanese translator, but I think this > sentence is translated differently when the translator sees the whole > line "Preparing ..., setting

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-05 Thread Junio C Hamano
Duy Nguyen writes: > On Sun, Feb 04, 2018 at 10:13:03PM +, Thomas Gummerer wrote: >> diff --git a/builtin/worktree.c b/builtin/worktree.c >> index 7cef5b120b..d1549e441d 100644 >> --- a/builtin/worktree.c >> +++ b/builtin/worktree.c >> @@ -303,7 +303,7 @@ static int add_worktree(const char *p

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-05 Thread Thomas Gummerer
On 02/05, Duy Nguyen wrote: > On Sun, Feb 04, 2018 at 10:13:03PM +, Thomas Gummerer wrote: > > diff --git a/builtin/worktree.c b/builtin/worktree.c > > index 7cef5b120b..d1549e441d 100644 > > --- a/builtin/worktree.c > > +++ b/builtin/worktree.c > > @@ -303,7 +303,7 @@ static int add_worktree(c

Re: [PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-04 Thread Duy Nguyen
On Sun, Feb 04, 2018 at 10:13:03PM +, Thomas Gummerer wrote: > diff --git a/builtin/worktree.c b/builtin/worktree.c > index 7cef5b120b..d1549e441d 100644 > --- a/builtin/worktree.c > +++ b/builtin/worktree.c > @@ -303,7 +303,7 @@ static int add_worktree(const char *path, const char > *refname,

[PATCH v2 1/3] worktree: improve message when creating a new worktree

2018-02-04 Thread Thomas Gummerer
Currently 'git worktree add' produces output like the following, when '--no-checkout' is not given: Preparing foo (identifier foo) HEAD is now at 26da330922 where the first line is written to stderr, and the second line coming from 'git reset --hard' is written to stdout, even though bot