Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-07-02 Thread Junio C Hamano
Duy Nguyen writes: >> So I'm all for a facility to have a setting to collectively opt-in to >> new things early. But I think for such a thing we really should a) at >> least in principle commit to making those things the default eventually > > Some features may be best enabled for certain setups.

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-07-02 Thread Derrick Stolee
On 7/2/2019 7:09 AM, Duy Nguyen wrote: > On Tue, Jul 2, 2019 at 5:47 PM Ævar Arnfjörð Bjarmason > wrote: >> >> >> On Wed, Jun 19 2019, Derrick Stolee via GitGitGadget wrote: >> >>> core.commitGraph:: >>> If true, then git will read the commit-graph file (if it exists) >>> - to parse th

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-07-02 Thread Duy Nguyen
On Tue, Jul 2, 2019 at 5:47 PM Ævar Arnfjörð Bjarmason wrote: > > > On Wed, Jun 19 2019, Derrick Stolee via GitGitGadget wrote: > > > core.commitGraph:: > > If true, then git will read the commit-graph file (if it exists) > > - to parse the graph structure of commits. Defaults to false.

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-07-02 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 19 2019, Derrick Stolee via GitGitGadget wrote: > core.commitGraph:: > If true, then git will read the commit-graph file (if it exists) > - to parse the graph structure of commits. Defaults to false. See > + to parse the graph structure of commits. Defaults to false, u

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-07-01 Thread Derrick Stolee
On 6/30/2019 2:35 PM, Carlo Arenas wrote: > On Fri, Jun 28, 2019 at 6:44 PM Derrick Stolee wrote: >> >> On 6/28/2019 5:42 PM, Junio C Hamano wrote: >>> "Derrick Stolee via GitGitGadget" writes: >>> >>> Use of "signed char" would be OK, but this is a singleton instance >>> per repository, so I am

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-30 Thread Carlo Arenas
On Fri, Jun 28, 2019 at 6:44 PM Derrick Stolee wrote: > > On 6/28/2019 5:42 PM, Junio C Hamano wrote: > > "Derrick Stolee via GitGitGadget" writes: > > > > Use of "signed char" would be OK, but this is a singleton instance > > per repository, so I am not sure how much it matters to save a few > >

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-28 Thread Derrick Stolee
On 6/28/2019 5:42 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> +struct repo_settings { >> +char core_commit_graph; >> +char gc_write_commit_graph; >> +}; > > I do not see a particular reason to favor type "char" here. "char" > is wider than e.g. "signed int :

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-28 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > @@ -41,7 +42,6 @@ static int aggressive_depth = 50; > static int aggressive_window = 250; > static int gc_auto_threshold = 6700; > static int gc_auto_pack_limit = 50; > -static int gc_write_commit_graph; > static int detach_auto = 1; > static times

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-28 Thread Derrick Stolee
On 6/28/2019 4:50 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> +core.featureAdoptionRate:: >> +Set an integer value on a scale from 0 to 10 describing your >> +desire to adopt new performance features. Defaults to 0. As >> +the value increases, features a

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-28 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > +core.featureAdoptionRate:: > + Set an integer value on a scale from 0 to 10 describing your > + desire to adopt new performance features. Defaults to 0. As > + the value increases, features are enabled by changing the > + default values

[PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

2019-06-19 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Several advanced config settings are highly recommended for clients using large repositories. Power users learn these one-by-one and enable them as they see fit. This could be made simpler, to allow more users to have access to these almost-always beneficial features (and mor