Re: [PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-24 Thread Christian Couder
On Sat, Jun 24, 2017 at 12:02 AM, Junio C Hamano wrote: > Christian Couder writes: >> Because of that, on repositories created with `git init --shared=all` >> and using the split index feature, one gets an error like: >> >> fatal: .git/sharedindex.a52f910b489bc462f187ab572ba0086f7b5157de: index

Re: [PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-23 Thread Junio C Hamano
Christian Couder writes: > Since f6ecc62dbf (write_shared_index(): use tempfile module, 2015-08-10) > write_shared_index() has been using mks_tempfile() to create the > temporary file that will become the shared index. > > But even before that, it looks like the functions used to create this > fi

Re: [PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-23 Thread Junio C Hamano
Christian Couder writes: > Since f6ecc62dbf (write_shared_index(): use tempfile module, 2015-08-10) > write_shared_index() has been using mks_tempfile() to create the > temporary file that will become the shared index. > > But even before that, it looks like the functions used to create this > fi

[PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-23 Thread Christian Couder
Since f6ecc62dbf (write_shared_index(): use tempfile module, 2015-08-10) write_shared_index() has been using mks_tempfile() to create the temporary file that will become the shared index. But even before that, it looks like the functions used to create this file didn't call adjust_shared_perm(), w