Re: [PATCH v2 1/3] Add tests for describe with --work-tree

2019-01-30 Thread Junio C Hamano
Duy Nguyen writes: >> My function is a modified version of check_describe(). > > Whoa. That function is 12 years old! I think our style has evolved a > bit since then. ;-). > I mean chaining within a test. This is to make sure any failure > triggers the test failure (as it should, if some comma

Re: [PATCH v2 1/3] Add tests for describe with --work-tree

2019-01-28 Thread Duy Nguyen
On Sun, Jan 27, 2019 at 08:13:51AM +0100, Sebastian Staudt wrote: > Am So., 27. Jan. 2019 um 01:07 Uhr schrieb Duy Nguyen : > > > > On Sun, Jan 27, 2019 at 3:51 AM Sebastian Staudt wrote: > > > > > > The dirty ones are already passing, but just because describe is comparing > > > with the wrong wo

Re: [PATCH v2 1/3] Add tests for describe with --work-tree

2019-01-26 Thread Sebastian Staudt
Am So., 27. Jan. 2019 um 01:07 Uhr schrieb Duy Nguyen : > > On Sun, Jan 27, 2019 at 3:51 AM Sebastian Staudt wrote: > > > > The dirty ones are already passing, but just because describe is comparing > > with the wrong working tree. > > > > Signed-off-by: Sebastian Staudt > > --- > > t/t6120-desc

Re: [PATCH v2 1/3] Add tests for describe with --work-tree

2019-01-26 Thread Duy Nguyen
On Sun, Jan 27, 2019 at 3:51 AM Sebastian Staudt wrote: > > The dirty ones are already passing, but just because describe is comparing > with the wrong working tree. > > Signed-off-by: Sebastian Staudt > --- > t/t6120-describe.sh | 24 > 1 file changed, 24 insertions(+)

[PATCH v2 1/3] Add tests for describe with --work-tree

2019-01-26 Thread Sebastian Staudt
The dirty ones are already passing, but just because describe is comparing with the wrong working tree. Signed-off-by: Sebastian Staudt --- t/t6120-describe.sh | 24 1 file changed, 24 insertions(+) diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index d639d94696