Re: [PATCH v2 1/2] sequencer: handle errors in read_author_ident()

2018-08-01 Thread Phillip Wood
Hi Eric Thanks for taking a look at this On 31/07/18 21:47, Eric Sunshine wrote: On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood wrote: The calling code treated NULL as a valid return value, so fix this by returning and integer and passing in a parameter to receive the author. It might be diff

Re: [PATCH v2 1/2] sequencer: handle errors in read_author_ident()

2018-07-31 Thread Eric Sunshine
On Tue, Jul 31, 2018 at 7:15 AM Phillip Wood wrote: > The calling code treated NULL as a valid return value, so fix this by > returning and integer and passing in a parameter to receive the author. It might be difficult for future readers (those who didn't follow the discussion) to understand how

[PATCH v2 1/2] sequencer: handle errors in read_author_ident()

2018-07-31 Thread Phillip Wood
From: Phillip Wood The calling code treated NULL as a valid return value, so fix this by returning and integer and passing in a parameter to receive the author. Signed-off-by: Phillip Wood --- sequencer.c | 49 ++--- 1 file changed, 26 insertions(+),