Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

2017-04-13 Thread Brandon Williams
On 04/13, Stefan Beller wrote: > On Thu, Apr 13, 2017 at 11:31 AM, Jacob Keller wrote: > > Spinning out a process is one of the big downsides of working with > > submodules in our code. Unfortunately, spinning out a process is also > > one of the biggest ways we isolate submodules, and if we wante

Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

2017-04-13 Thread Stefan Beller
On Thu, Apr 13, 2017 at 11:31 AM, Jacob Keller wrote: > Spinning out a process is one of the big downsides of working with > submodules in our code. Unfortunately, spinning out a process is also > one of the biggest ways we isolate submodules, and if we wanted to do > this "in-process" we would ne

Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

2017-04-13 Thread Jacob Keller
On Thu, Apr 13, 2017 at 11:03 AM, Brandon Williams wrote: > On 04/13, Jacob Keller wrote: >> From: Jacob Keller >> >> Since commit e77aa336f116 ("ls-files: optionally recurse into >> submodules", 2016-10-07) ls-files has known how to recurse into >> submodules when displaying files. >> >> Unfortu

Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

2017-04-13 Thread Brandon Williams
On 04/13, Jacob Keller wrote: > From: Jacob Keller > > Since commit e77aa336f116 ("ls-files: optionally recurse into > submodules", 2016-10-07) ls-files has known how to recurse into > submodules when displaying files. > > Unfortunately this fails for certain cases, including when nesting more >

[PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

2017-04-13 Thread Jacob Keller
From: Jacob Keller Since commit e77aa336f116 ("ls-files: optionally recurse into submodules", 2016-10-07) ls-files has known how to recurse into submodules when displaying files. Unfortunately this fails for certain cases, including when nesting more than one submodule, called from within a subm