Re: [PATCH v2 1/2] completion: Add sequencer function

2015-06-01 Thread SZEDER Gábor
Quoting Junio C Hamano : SZEDER Gábor writes: I don't see the benefits of this change. This patch adds more than twice as many lines as it removes, and patch 2/2 adds 8 new lines although it could get away with only 5 without this function. To offer sequencer options we currently go throug

Re: [PATCH v2 1/2] completion: Add sequencer function

2015-06-01 Thread Junio C Hamano
SZEDER Gábor writes: > I don't see the benefits of this change. This patch adds more than > twice as many lines as it removes, and patch 2/2 adds 8 new lines > although it could get away with only 5 without this function. To > offer sequencer options we currently go through a single if st

Re: [PATCH v2 1/2] completion: Add sequencer function

2015-05-30 Thread SZEDER Gábor
Quoting Thomas Braun : Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 48 +++--- 1 file changed, 33 insertions(+), 15 deletions(-) I don't see the benefits of this change. This patch adds more than twice as many lines as it removes

[PATCH v2 1/2] completion: Add sequencer function

2015-05-30 Thread Thomas Braun
Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 48 +++--- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index bfc74e9..f6e5bf6 100644 --- a/cont

[PATCH v2 1/2] completion: Add sequencer function

2015-05-30 Thread Thomas Braun
Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 48 +++--- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index bfc74e9..f6e5bf6 100644 --- a/cont