Re: [PATCH v2 1/2] Use packet_reader instead of packet_read_line

2019-01-08 Thread Masaya Suzuki
On Mon, Jan 7, 2019 at 2:33 PM Josh Steadmon wrote: > > On 2018.12.29 13:19, Masaya Suzuki wrote: > > By using and sharing a packet_reader while handling a Git pack protocol > > request, the same reader option is used throughout the code. This makes > > it easy to set a reader option to the reques

Re: [PATCH v2 1/2] Use packet_reader instead of packet_read_line

2019-01-07 Thread Josh Steadmon
On 2018.12.29 13:19, Masaya Suzuki wrote: > By using and sharing a packet_reader while handling a Git pack protocol > request, the same reader option is used throughout the code. This makes > it easy to set a reader option to the request parsing code. > > Signed-off-by: Masaya Suzuki > --- > bui

Re: [PATCH v2 1/2] Use packet_reader instead of packet_read_line

2019-01-07 Thread Jonathan Tan
> By using and sharing a packet_reader while handling a Git pack protocol > request, the same reader option is used throughout the code. This makes > it easy to set a reader option to the request parsing code. I see that packet_read() and packet_read_line_buf() invocations are also removed, so it

[PATCH v2 1/2] Use packet_reader instead of packet_read_line

2018-12-29 Thread Masaya Suzuki
By using and sharing a packet_reader while handling a Git pack protocol request, the same reader option is used throughout the code. This makes it easy to set a reader option to the request parsing code. Signed-off-by: Masaya Suzuki --- builtin/archive.c | 19 ++--- builtin/receive-