Hi Johannes
On Wed, Feb 27, 2019 at 1:33 AM Johannes Schindelin
wrote:
>
> I think what Gábor meant was that both `test ! -f file` and `! test -f
> file` should be converted to `test_path_is_missing file`.
>
I'll work over this and submit the patch.
Thanks for clarifying
Rohit
Hi Rohit,
On Wed, 27 Feb 2019, Rohit Ashiwal wrote:
> On Tue, Feb 26, 2019 at 10:07 PM SZEDER Gábor wrote:
>
> > Furthermore, there are a couple of place where the '!' is not in front
> > of the whole 'test' command but is given as an argument, e.g.:
> >
> > test ! -f file
> >
> > Please conve
Hi SZEDER
On Tue, Feb 26, 2019 at 10:07 PM SZEDER Gábor wrote:
>
> We prefer to use imperative mode when talking about what a patch does,
> as if the author were to give orders to the code base. So e.g.
> instead of
>
> This patch will ...
>
> we would usually write something like this:
>
>
Hi and welcome!
On Tue, Feb 26, 2019 at 06:26:09AM -0800, Rohit Ashiwal via GitGitGadget wrote:
> Previously we were using `test -(d|f)` to verify
> the presence of a directory/file, but we already
> have helper functions, viz, `test_path_is_dir`
> and `test_path_is_file` with better functionality
From: Rohit Ashiwal
Previously we were using `test -(d|f)` to verify
the presence of a directory/file, but we already
have helper functions, viz, `test_path_is_dir`
and `test_path_is_file` with better functionality.
This patch will replace `test -(d|f)` calls in t3660.sh
These helper functions m
5 matches
Mail list logo
