Re: [PATCH v2 09/12] worktree.c: test if branch being rebased in another worktree

2016-04-20 Thread Duy Nguyen
On Thu, Apr 21, 2016 at 1:04 AM, Junio C Hamano wrote: >> diff --git a/builtin/checkout.c b/builtin/checkout.c >> index efcbd8f..6041718 100644 >> --- a/builtin/checkout.c >> +++ b/builtin/checkout.c >> @@ -,7 +,7 @@ static int checkout_branch(struct checkout_opts *opts, >> c

Re: [PATCH v2 09/12] worktree.c: test if branch being rebased in another worktree

2016-04-20 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Subject: Re: [PATCH v2 09/12] worktree.c: test if branch being rebased in > another worktree Lacks the verb? Perhaps s/being/is/ is sufficient. > This function find_shared_symref() is used in a couple places: > > 1) in builtin/branch.c: it'

[PATCH v2 09/12] worktree.c: test if branch being rebased in another worktree

2016-04-20 Thread Nguyễn Thái Ngọc Duy
This function find_shared_symref() is used in a couple places: 1) in builtin/branch.c: it's used to detect if a branch is checked out elsewhere and refuse to delete the branch. 2) in builtin/notes.c: it's used to detect if a note is being merged in another worktree 3) in branch.c, the func