Re: [PATCH v2 06/14] imap-send.c: remove some unused fields from struct store

2013-01-16 Thread Michael Haggerty
On 01/15/2013 09:32 PM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> -else if ((arg1 = next_arg(&cmd))) { >> -if (!strcmp("EXISTS", arg1)) >> -ctx->gen.count = atoi(arg); >> -el

Re: [PATCH v2 06/14] imap-send.c: remove some unused fields from struct store

2013-01-15 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> Since actually fixing that is probably too aggressive for this patch, >> how about a FIXME comment like the following? [...] > Hmph; it seems that it is not worth rerolling the whole thing only > for this, so let me squash this in, replacing the

Re: [PATCH v2 06/14] imap-send.c: remove some unused fields from struct store

2013-01-15 Thread Junio C Hamano
Jonathan Nieder writes: > Michael Haggerty wrote: > >> -else if ((arg1 = next_arg(&cmd))) { >> -if (!strcmp("EXISTS", arg1)) >> -ctx->gen.count = atoi(arg); >> -else if (!strcmp("RECENT

Re: [PATCH v2 06/14] imap-send.c: remove some unused fields from struct store

2013-01-15 Thread Jonathan Nieder
Michael Haggerty wrote: > - else if ((arg1 = next_arg(&cmd))) { > - if (!strcmp("EXISTS", arg1)) > - ctx->gen.count = atoi(arg); > - else if (!strcmp("RECENT", arg1)) > -

[PATCH v2 06/14] imap-send.c: remove some unused fields from struct store

2013-01-15 Thread Michael Haggerty
Signed-off-by: Michael Haggerty --- imap-send.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/imap-send.c b/imap-send.c index 9e181e0..f193211 100644 --- a/imap-send.c +++ b/imap-send.c @@ -36,12 +36,7 @@ typedef void *SSL; struct store { /* curren