Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

On Sat, Jul 11, 2015 at 2:56 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Fri, Jul 10, 2015 at 10:13 PM, Junio C Hamano wrote: >>> Karthik Nayak writes: >>> Since 'ref-filter' only has an option to match path names add an option for regular pattern matching. >>> >>> There i

Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

Karthik Nayak writes: > On Fri, Jul 10, 2015 at 10:13 PM, Junio C Hamano wrote: >> Karthik Nayak writes: >> >>> Since 'ref-filter' only has an option to match path names >>> add an option for regular pattern matching. >> >> There is nothing "regular" about the pattern matching you are >> adding

Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

On Fri, Jul 10, 2015 at 10:13 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> Since 'ref-filter' only has an option to match path names >> add an option for regular pattern matching. > > There is nothing "regular" about the pattern matching you are > adding. > > Everywhere else we use patt

Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

Karthik Nayak writes: > Since 'ref-filter' only has an option to match path names > add an option for regular pattern matching. There is nothing "regular" about the pattern matching you are adding. Everywhere else we use patterns on refs we call wildmatch(), which is an enhanced implementation

Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

On Thu, Jul 9, 2015 at 7:02 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> Since 'ref-filter' only has an option to match path names >> add an option for regular pattern matching. > > Here also, a hint on why this is needed would be welcome. > Will add. >> --- a/ref-filter.c >> +++ b/ref-

Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

Karthik Nayak writes: > Since 'ref-filter' only has an option to match path names > add an option for regular pattern matching. Here also, a hint on why this is needed would be welcome. > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -956,6 +956,20 @@ static int commit_contains(struct ref_filter

[PATCH v2 05/10] ref-filter: add option to match literal pattern

Since 'ref-filter' only has an option to match path names add an option for regular pattern matching. Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- builtin/for-each-ref.c | 1 + ref-filter.c | 25 - ref-filter.h