Re: [PATCH v2 04/19] pull: implement skeletal builtin pull

2015-06-09 Thread Junio C Hamano
Paul Tan writes: > +int cmd_pull(int argc, const char **argv, const char *prefix) > +{ > + if (!getenv("_GIT_USE_BUILTIN_PULL")) { > + const char *path = mkpath("%s/git-pull", git_exec_path()); > + > + if (sane_execvp(path, (char**) argv) < 0) Style: "(char **)argv".

[PATCH v2 04/19] pull: implement skeletal builtin pull

2015-06-02 Thread Paul Tan
For the purpose of rewriting git-pull.sh into a C builtin, implement a skeletal builtin/pull.c that redirects to $GIT_EXEC_PATH/git-pull.sh if the environment variable _GIT_USE_BUILTIN_PULL is not defined. This allows us to fall back on the functional git-pull.sh when running the test suite for tes