Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id

2017-05-03 Thread brian m. carlson
On Tue, May 02, 2017 at 11:13:08AM -0700, Brandon Williams wrote: > Should this 20 be converted to GIT_{SHA1,MAX}_RAWSZ? I know this is a > generated patch so maybe this is addressed, or will be addressed later? Since this is a purely mechanical patch, I plan on addressing it later. I'll probably

Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id

2017-05-02 Thread Brandon Williams
On 05/01, brian m. carlson wrote: > Convert the sha1 member of struct cache_tree to struct object_id by > changing the definition and applying the following semantic patch, plus > the standard object_id transforms: > > @@ > struct cache_tree E1; > @@ > - E1.sha1 > + E1.oid.hash > > @@ > struct ca

[PATCH v2 03/53] Convert struct cache_tree to use struct object_id

2017-04-30 Thread brian m. carlson
Convert the sha1 member of struct cache_tree to struct object_id by changing the definition and applying the following semantic patch, plus the standard object_id transforms: @@ struct cache_tree E1; @@ - E1.sha1 + E1.oid.hash @@ struct cache_tree *E1; @@ - E1->sha1 + E1->oid.hash Fix up one ref