Re: [PATCH v2 03/25] object_array: factor out slopbuf-freeing logic

2014-10-16 Thread Junio C Hamano
Jeff King writes: > This is not a lot of code, but it's a logical construct that > should not need to be repeated (and we are about to add a > third repetition). Good, but I have two and a half tangential comments about the context that appears in this patch ;-) > void object_array_filter(stru

[PATCH v2 03/25] object_array: factor out slopbuf-freeing logic

2014-10-15 Thread Jeff King
This is not a lot of code, but it's a logical construct that should not need to be repeated (and we are about to add a third repetition). Signed-off-by: Jeff King --- object.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/object.c b/object.c index ca9d790.