Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-16 Thread Ramsay Jones
On 16/12/13 17:11, Jonathan Nieder wrote: > Duy Nguyen wrote: Ramsay Jones wrote: > > :-D I renamed this _from_ git_vsnpath() in commit 5b3b8fa2 ("path.c: > Remove the > 'git_' prefix from a file scope function", 04-09-2012), because ... well > it's a > file scope functi

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-16 Thread Junio C Hamano
Jonathan Nieder writes: > Duy Nguyen wrote: Ramsay Jones wrote: > > :-D I renamed this _from_ git_vsnpath() in commit 5b3b8fa2 ("path.c: > Remove the > 'git_' prefix from a file scope function", 04-09-2012), because ... well > it's a > file scope function! (i.e. the git

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-16 Thread Jonathan Nieder
Duy Nguyen wrote: >>> Ramsay Jones wrote: :-D I renamed this _from_ git_vsnpath() in commit 5b3b8fa2 ("path.c: Remove the 'git_' prefix from a file scope function", 04-09-2012), because ... well it's a file scope function! (i.e. the git_ prefix implies greater than file

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-15 Thread Duy Nguyen
On Mon, Dec 16, 2013 at 4:13 AM, Ramsay Jones wrote: -static char *vsnpath(char *buf, size_t n, const char *fmt, va_list args) +static char *git_vsnpath(char *buf, size_t n, const char *fmt, va_list args) >>> >>> :-D I renamed this _from_ git_vsnpath() in commit 5b3b8fa2 ("path.c:

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-15 Thread Ramsay Jones
On 15/12/13 02:25, Duy Nguyen wrote: > On Sun, Dec 15, 2013 at 3:23 AM, Ramsay Jones > wrote: >> On 14/12/13 10:54, Nguyễn Thái Ngọc Duy wrote: >>> This is the underlying implementation of git_path(), git_pathdup() and >>> git_snpath() which will prefix $GIT_DIR in the result string. Put git_ >>>

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-14 Thread Duy Nguyen
On Sun, Dec 15, 2013 at 3:23 AM, Ramsay Jones wrote: > On 14/12/13 10:54, Nguyễn Thái Ngọc Duy wrote: >> This is the underlying implementation of git_path(), git_pathdup() and >> git_snpath() which will prefix $GIT_DIR in the result string. Put git_ >> prefix in front of it to avoid the confusion

Re: [PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-14 Thread Ramsay Jones
On 14/12/13 10:54, Nguyễn Thái Ngọc Duy wrote: > This is the underlying implementation of git_path(), git_pathdup() and > git_snpath() which will prefix $GIT_DIR in the result string. Put git_ > prefix in front of it to avoid the confusion that this is a generic > path handling function.# > > Sign

[PATCH v2 02/21] path.c: rename vsnpath() to git_vsnpath()

2013-12-14 Thread Nguyễn Thái Ngọc Duy
This is the underlying implementation of git_path(), git_pathdup() and git_snpath() which will prefix $GIT_DIR in the result string. Put git_ prefix in front of it to avoid the confusion that this is a generic path handling function.# Signed-off-by: Nguyễn Thái Ngọc Duy --- path.c | 8