Re: [PATCH v2 02/18] cat-file: reuse struct ref_format

2018-01-16 Thread Оля Тележная
2018-01-16 0:37 GMT+03:00 Jeff King : > On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > >> Start using ref_format struct instead of simple char*. >> Need that for further reusing of formatting logic from ref-filter. > > OK, this makes sense (though again, at some point we want th

Re: [PATCH v2 02/18] cat-file: reuse struct ref_format

2018-01-15 Thread Jeff King
On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > Start using ref_format struct instead of simple char*. > Need that for further reusing of formatting logic from ref-filter. OK, this makes sense (though again, at some point we want this to stop being a "ref_format" and just be a

[PATCH v2 02/18] cat-file: reuse struct ref_format

2018-01-10 Thread Olga Telezhnaya
Start using ref_format struct instead of simple char*. Need that for further reusing of formatting logic from ref-filter. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- builtin/cat-file.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletio