Re: [PATCH v2 02/15] submodule: don't use submodule_from_name

2017-08-11 Thread Heiko Voigt
On Fri, Aug 04, 2017 at 02:53:11PM -0700, Brandon Williams wrote: > On 08/03, Stefan Beller wrote: > > On Thu, Aug 3, 2017 at 11:19 AM, Brandon Williams wrote: > > > The function 'submodule_from_name()' is being used incorrectly here as a > > > submodule path is being used instead of a submodule n

Re: [PATCH v2 02/15] submodule: don't use submodule_from_name

2017-08-04 Thread Brandon Williams
On 08/03, Stefan Beller wrote: > On Thu, Aug 3, 2017 at 11:19 AM, Brandon Williams wrote: > > The function 'submodule_from_name()' is being used incorrectly here as a > > submodule path is being used instead of a submodule name. Since the > > correct function to use with a path to a submodule is

Re: [PATCH v2 02/15] submodule: don't use submodule_from_name

2017-08-03 Thread Junio C Hamano
Brandon Williams writes: > The function 'submodule_from_name()' is being used incorrectly here as a > submodule path is being used instead of a submodule name. Since the > correct function to use with a path to a submodule is already being used > ('submodule_from_path()') let's remove the call t

Re: [PATCH v2 02/15] submodule: don't use submodule_from_name

2017-08-03 Thread Stefan Beller
On Thu, Aug 3, 2017 at 11:19 AM, Brandon Williams wrote: > The function 'submodule_from_name()' is being used incorrectly here as a > submodule path is being used instead of a submodule name. Since the > correct function to use with a path to a submodule is already being used > ('submodule_from_p

[PATCH v2 02/15] submodule: don't use submodule_from_name

2017-08-03 Thread Brandon Williams
The function 'submodule_from_name()' is being used incorrectly here as a submodule path is being used instead of a submodule name. Since the correct function to use with a path to a submodule is already being used ('submodule_from_path()') let's remove the call to 'submodule_from_name()'. Signed-