Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-24 Thread Michael Haggerty
On 06/24/2017 03:11 AM, Jeff King wrote: > On Fri, Jun 23, 2017 at 02:47:01PM -0700, Junio C Hamano wrote: > >>> Speculating on my own question. I guess it would prepare us for a day >>> when a possible ref store is to use a packed-refs _without_ loose refs. >>> IOW, the property is defined on pac

Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Jeff King
On Fri, Jun 23, 2017 at 02:47:01PM -0700, Junio C Hamano wrote: > > Speculating on my own question. I guess it would prepare us for a day > > when a possible ref store is to use a packed-refs _without_ loose refs. > > IOW, the property is defined on packed-refs today, but a possible future > > dir

Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Junio C Hamano
Jeff King writes: > On Fri, Jun 23, 2017 at 03:01:59PM -0400, Jeff King wrote: > >> On Fri, Jun 23, 2017 at 09:01:18AM +0200, Michael Haggerty wrote: >> >> > * Change patch 17 "packed_ref_store: support iteration" to always >> > iterate over the packed refs using `DO_FOR_EACH_INCLUDE_BROKEN`.

Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Junio C Hamano
Jeff King writes: > On Fri, Jun 23, 2017 at 09:01:18AM +0200, Michael Haggerty wrote: > >> * Change patch 17 "packed_ref_store: support iteration" to always >> iterate over the packed refs using `DO_FOR_EACH_INCLUDE_BROKEN`. >> This switches off the check in the packed-ref iterator of whether

Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Jeff King
On Fri, Jun 23, 2017 at 03:01:59PM -0400, Jeff King wrote: > On Fri, Jun 23, 2017 at 09:01:18AM +0200, Michael Haggerty wrote: > > > * Change patch 17 "packed_ref_store: support iteration" to always > > iterate over the packed refs using `DO_FOR_EACH_INCLUDE_BROKEN`. > > This switches off the

Re: [PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Jeff King
On Fri, Jun 23, 2017 at 09:01:18AM +0200, Michael Haggerty wrote: > * Change patch 17 "packed_ref_store: support iteration" to always > iterate over the packed refs using `DO_FOR_EACH_INCLUDE_BROKEN`. > This switches off the check in the packed-ref iterator of whether a > reference is broken

[PATCH v2 00/29] Create a reference backend for packed refs

2017-06-23 Thread Michael Haggerty
This is v2 of a patch series creating a `packed_ref_store` reference backend. Thanks to Stefan, Junio, and Peff for their comments about v1 [1]. Changes since v1: * Picked up some whitespace fixes that Junio applied when importing v1. * A new patch 01 adds a test (written by Junio) that a broken