Re: [PATCH v2 00/19] Index-v5

2013-07-19 Thread Junio C Hamano
Thomas Gummerer writes: > What I currently did is add a environment variable GIT_INDEX_VERSION > that is used only if there is no index yet, to make sure existing > repositories aren't affected and still have to be converted explicitly > by using git update-index. > > For the tests I simply did e

Re: [PATCH v2 00/19] Index-v5

2013-07-19 Thread Thomas Gummerer
Junio C Hamano writes: > Thomas Gummerer writes: > >> Ah ok, I understand. I think it's best to add a GIT_INDEX_VERSION=x >> config option to config.mak, where x is the index version that should be >> tested. > > Whatever you do, please do not call it GIT_INDEX_VERSION _if_ it is > only to be u

Re: [PATCH v2 00/19] Index-v5

2013-07-17 Thread Junio C Hamano
Thomas Gummerer writes: > Ah ok, I understand. I think it's best to add a GIT_INDEX_VERSION=x > config option to config.mak, where x is the index version that should be > tested. Whatever you do, please do not call it GIT_INDEX_VERSION _if_ it is only to be used while testing. Have string "TES

Re: [PATCH v2 00/19] Index-v5

2013-07-17 Thread Thomas Gummerer
Duy Nguyen writes: > On Mon, Jul 15, 2013 at 4:30 PM, Thomas Gummerer wrote: >> Duy Nguyen writes: >> >>> On Sat, Jul 13, 2013 at 12:26 AM, Thomas Gummerer >>> wrote: t/perf/p0003-index.sh| 59 + t/t2104-update-index-skip-worktree.sh|1

Re: [PATCH v2 00/19] Index-v5

2013-07-17 Thread Thomas Gummerer
Ramsay Jones writes: > Thomas Gummerer wrote: >> Hi, >> >> previous rounds (without api) are at $gmane/202752, $gmane/202923, >> $gmane/203088 and $gmane/203517, the previous round with api was at >> $gmane/229732. Thanks to Junio, Duy and Eric for their comments on >> the previous round. > > If

Re: [PATCH v2 00/19] Index-v5

2013-07-16 Thread Ramsay Jones
Thomas Gummerer wrote: > Hi, > > previous rounds (without api) are at $gmane/202752, $gmane/202923, > $gmane/203088 and $gmane/203517, the previous round with api was at > $gmane/229732. Thanks to Junio, Duy and Eric for their comments on > the previous round. If I remember correctly, the origin

Re: [PATCH v2 00/19] Index-v5

2013-07-15 Thread Duy Nguyen
On Mon, Jul 15, 2013 at 4:30 PM, Thomas Gummerer wrote: > Duy Nguyen writes: > >> On Sat, Jul 13, 2013 at 12:26 AM, Thomas Gummerer >> wrote: >>> t/perf/p0003-index.sh| 59 + >>> t/t2104-update-index-skip-worktree.sh|1 + >> >> For such a big code a

Re: [PATCH v2 00/19] Index-v5

2013-07-15 Thread Thomas Gummerer
Duy Nguyen writes: > On Sat, Jul 13, 2013 at 12:26 AM, Thomas Gummerer > wrote: >> t/perf/p0003-index.sh| 59 + >> t/t2104-update-index-skip-worktree.sh|1 + > > For such a big code addition, the test part seems modest. Speaking > from my experience

Re: [PATCH v2 00/19] Index-v5

2013-07-13 Thread Duy Nguyen
On Sat, Jul 13, 2013 at 12:26 AM, Thomas Gummerer wrote: > t/perf/p0003-index.sh| 59 + > t/t2104-update-index-skip-worktree.sh|1 + For such a big code addition, the test part seems modest. Speaking from my experience, I rarely run perf tests and "ma

[PATCH v2 00/19] Index-v5

2013-07-12 Thread Thomas Gummerer
Hi, previous rounds (without api) are at $gmane/202752, $gmane/202923, $gmane/203088 and $gmane/203517, the previous round with api was at $gmane/229732. Thanks to Junio, Duy and Eric for their comments on the previous round. Changes since the previous round: Add documentation for the index rea