Re: [PATCH v2 00/14] Remove unused code from imap-send.c

Michael Haggerty wrote: > imap-send.c | 308 > +++- > 1 file changed, 55 insertions(+), 253 deletions(-) Patch 14 is lovely. Except for patch 6, for what it's worth these are all Reviewed-by: Jonathan Nieder Nicely done. -- To unsubscr

Re: [PATCH v2 00/14] Remove unused code from imap-send.c

On Tue, Jan 15, 2013 at 09:06:18AM +0100, Michael Haggerty wrote: > This is a re-roll, incorporating the feedback of Jonathan Nieder > (thanks!). Thanks, I don't see anything wrong with this from a cursory reading. > * Added some comments to lf_to_crlf(), simplified the code a bit > further, a

[PATCH v2 00/14] Remove unused code from imap-send.c

This is a re-roll, incorporating the feedback of Jonathan Nieder (thanks!). Differences from v1: * Added comments to get_cmd_result() at the place where the "NAMESPACE" response is skipped over. * Added some comments to lf_to_crlf(), simplified the code a bit further, and expanded the commit