Re: [PATCH v2 00/13] format-patch: clean up tests and documentation

2019-09-05 Thread Denton Liu
On Thu, Sep 05, 2019 at 12:56:06PM -0700, Junio C Hamano wrote: > Denton Liu writes: > > > Hi Junio, > > > > I see that "dl/format-patch-doc-test-cleanup" currently has the comment > > "Expecting a reroll." This should be the reroll that you're expecting ;) > > > > Also, since there haven't been

Re: [PATCH v2 00/13] format-patch: clean up tests and documentation

2019-09-05 Thread Junio C Hamano
Denton Liu writes: > Hi Junio, > > I see that "dl/format-patch-doc-test-cleanup" currently has the comment > "Expecting a reroll." This should be the reroll that you're expecting ;) > > Also, since there haven't been any comments on the topic in a while, I > propose that it should be ready for in

Re: [PATCH v2 00/13] format-patch: clean up tests and documentation

2019-09-04 Thread Denton Liu
Hi Junio, I see that "dl/format-patch-doc-test-cleanup" currently has the comment "Expecting a reroll." This should be the reroll that you're expecting ;) Also, since there haven't been any comments on the topic in a while, I propose that it should be ready for inclusion. Thanks, Denton On Tue

[PATCH v2 00/13] format-patch: clean up tests and documentation

2019-08-26 Thread Denton Liu
In this reroll, I squashed Junio's suggestion into the correct patch. Also, I took Eric's suggestion and removed the weak justification (i.e. better error messages) from the sed patch since it doesn't really contribute. As one of the older parts of the Git, the tests and documentation for format-