Re: [PATCH v2 0/9] Store submodules in a hash, not a linked list

2017-02-12 Thread David Turner
On Fri, 2017-02-10 at 12:16 +0100, Michael Haggerty wrote: > This is v2 of the patch series, considerably reorganized but not that > different codewise. Thanks to Stefan, Junio, and Peff for their > feedback about v1 [1]. I think I have addressed all of your comments. LGTM.

Re: [PATCH v2 0/9] Store submodules in a hash, not a linked list

2017-02-10 Thread Junio C Hamano
Michael Haggerty writes: > This is v2 of the patch series, considerably reorganized but not that > different codewise. Thanks. The way the series loses "!*submodule and !submodule are the same thing, sometimes" is easier to follow when presented in this order, at least to me.

Re: [PATCH v2 0/9] Store submodules in a hash, not a linked list

2017-02-10 Thread Stefan Beller
On Fri, Feb 10, 2017 at 7:56 AM, Jeff King wrote: > On Fri, Feb 10, 2017 at 12:16:10PM +0100, Michael Haggerty wrote: > >> This is v2 of the patch series, considerably reorganized but not that >> different codewise. Thanks to Stefan, Junio, and Peff for their >> feedback about v1 [1]. I think I ha

Re: [PATCH v2 0/9] Store submodules in a hash, not a linked list

2017-02-10 Thread Jeff King
On Fri, Feb 10, 2017 at 12:16:10PM +0100, Michael Haggerty wrote: > This is v2 of the patch series, considerably reorganized but not that > different codewise. Thanks to Stefan, Junio, and Peff for their > feedback about v1 [1]. I think I have addressed all of your comments. > > Changes since v1:

[PATCH v2 0/9] Store submodules in a hash, not a linked list

2017-02-10 Thread Michael Haggerty
This is v2 of the patch series, considerably reorganized but not that different codewise. Thanks to Stefan, Junio, and Peff for their feedback about v1 [1]. I think I have addressed all of your comments. Changes since v1: * Rebase from `master` onto `maint` (to match Junio). * Reorder some commi