Re: [PATCH v2 0/8] CDN offloading of fetch response

2019-04-24 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 08 2019, Jonathan Tan wrote: > One relatively significant change: someone pointed out that the issue fixed by > 50d3413740 ("http: make redirects more obvious", 2016-12-06) could also > occur here, so I have changed it so that the server is required to send > the packfile's hash alon

Re: [PATCH v2 0/8] CDN offloading of fetch response

2019-04-23 Thread Jonathan Tan
> On Fri, Mar 08, 2019 at 01:55:12PM -0800, Jonathan Tan wrote: > > > Here's my current progress - the only thing that is lacking is more > > tests, maybe, so I think it's ready for review. > > A bit belated, but here are some overall thoughts. A lot of my thinking > comes from comparing this to

Re: [PATCH v2 0/8] CDN offloading of fetch response

2019-04-22 Thread Jeff King
On Fri, Mar 08, 2019 at 01:55:12PM -0800, Jonathan Tan wrote: > Here's my current progress - the only thing that is lacking is more > tests, maybe, so I think it's ready for review. A bit belated, but here are some overall thoughts. A lot of my thinking comes from comparing this to previous work

Re: [PATCH v2 0/8] CDN offloading of fetch response

2019-03-19 Thread Josh Steadmon
On 2019.03.08 13:55, Jonathan Tan wrote: > Here's my current progress - the only thing that is lacking is more > tests, maybe, so I think it's ready for review. This series looks good to me. Reviewed-by: Josh Steadmon

[PATCH v2 0/8] CDN offloading of fetch response

2019-03-08 Thread Jonathan Tan
Here's my current progress - the only thing that is lacking is more tests, maybe, so I think it's ready for review. I wrote in version 1: > I know > that there are some implementation details that could be improved (e.g. > parallelization of the CDN downloads, starting CDN downloads *after* > clo