Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-04-06 Thread Jeff Hostetler
On 4/5/2017 10:22 PM, Duy Nguyen wrote: On Thu, Mar 23, 2017 at 8:46 PM, wrote: This patch series is a performance optimization for lazy_init_name_hash() in name-hash.c on very large repositories. This change allows lazy_init_name_hash() to optionally use multiple threads when building the

Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-04-05 Thread Duy Nguyen
On Thu, Mar 23, 2017 at 8:46 PM, wrote: > This patch series is a performance optimization for > lazy_init_name_hash() in name-hash.c on very large > repositories. > > This change allows lazy_init_name_hash() to optionally > use multiple threads when building the the_index.dir_hash > and the_index

Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-03-24 Thread Junio C Hamano
Jeff Hostetler writes: > WRT the assert() in name-hash.c, Stefan suggested converting it > to an if-!-die form in an earlier message in this thread. I'm OK > with that or with removing the assert completely. I actually am OK with leaving things as they are ;-)

Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-03-24 Thread Stefan Beller
On Fri, Mar 24, 2017 at 5:39 AM, Jeff Hostetler wrote: > WRT the assert() in name-hash.c, Stefan suggested converting it > to an if-!-die form in an earlier message in this thread. I'm OK > with that or with removing the assert completely. I think removing them completely sounds even better. Th

Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-03-24 Thread Jeff Hostetler
On 3/23/2017 1:52 PM, Junio C Hamano wrote: The API document update in 4/7 is a nice addition and it comes at the right spot in the series, just after API enhancement is done. I gave a quick reading on it twice, and all looked reasonable. Nicely done. Thanks. I queued the sparse things Ra

Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-03-23 Thread Junio C Hamano
g...@jeffhostetler.com writes: > From: Jeff Hostetler > > Version 2 of this patch series addresses the coding > style issues, compile errors in non-threaded builds, > and updated API documentation. > > > This patch series is a performance optimization for > lazy_init_name_hash() in name-hash.c on

[PATCH v2 0/7] thread lazy_init_name_hash

2017-03-23 Thread git
From: Jeff Hostetler Version 2 of this patch series addresses the coding style issues, compile errors in non-threaded builds, and updated API documentation. This patch series is a performance optimization for lazy_init_name_hash() in name-hash.c on very large repositories. This change allows l