Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 26 2019, Ævar Arnfjörð Bjarmason wrote: > ...speaking of which, digging up outstanding stuff I have on the > commit-graph I was reminded to finish up my "commit graph on clone" > patch in: > https://public-inbox.org/git/87in2hgzin@evledraar.gmail.com/ > > And re #1 above: I guess

Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-26 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 26 2019, Derrick Stolee wrote: > On 4/26/2019 4:33 AM, Ævar Arnfjörð Bjarmason wrote: >> >> On Fri, Apr 26 2019, Junio C Hamano wrote: >>> >>> Thanks always for your careful review and thoughtful comments, by >>> the way. > > I agree that these comments are extremely helpful. >

Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-26 Thread Derrick Stolee
On 4/26/2019 4:33 AM, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Apr 26 2019, Junio C Hamano wrote: >> >> Thanks always for your careful review and thoughtful comments, by >> the way. I agree that these comments are extremely helpful. >>> Now as noted in my series we now on 'master' downgrade th

Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-26 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 26 2019, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> On Wed, Apr 24 2019, Derrick Stolee via GitGitGadget wrote: >> >>> NOTE: this series was rebased onto ab/commit-graph-fixes, as the conflicts >>> were significant and subtle. >> >> Sorry, hopefully it helped more

Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-25 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Apr 24 2019, Derrick Stolee via GitGitGadget wrote: > >> NOTE: this series was rebased onto ab/commit-graph-fixes, as the conflicts >> were significant and subtle. > > Sorry, hopefully it helped more than it harmed :) > > A few unrelated things: Thanks a

Re: [PATCH v2 0/5] Create commit-graph file format v2

2019-04-25 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, Derrick Stolee via GitGitGadget wrote: > NOTE: this series was rebased onto ab/commit-graph-fixes, as the conflicts > were significant and subtle. Sorry, hopefully it helped more than it harmed :) A few unrelated things: 1) First, before that series of mine applying this

[PATCH v2 0/5] Create commit-graph file format v2

2019-04-24 Thread Derrick Stolee via GitGitGadget
The commit-graph file format has some shortcomings that were discussed on-list: 1. It doesn't use the 4-byte format ID from the_hash_algo. 2. There is no way to change the reachability index from generation numbers to corrected commit date [1]. 3. The unused byte in the