Re: [PATCH v2 0/3] rebase: give precise error message

2017-11-28 Thread Junio C Hamano
Kaartic Sivaraam writes: >> I do not think the above is a good change in the first place for at >> least two reasons. By saying , the updated text says "not just >> branches but you can also give tags and remote-tracking branches". > > I used as you could actually use tags, remote-tracking bran

Re: [PATCH v2 0/3] rebase: give precise error message

2017-11-28 Thread Kaartic Sivaraam
On Wed, 2017-11-29 at 09:10 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > If is the correct substitute , I could try to send a > > patch that fixes this. > > I do not think the above is a good change in the first place for at > least two reasons. By saying , the updated text sa

Re: [PATCH v2 0/3] rebase: give precise error message

2017-11-28 Thread Junio C Hamano
Kaartic Sivaraam writes: > Something like the following diff with additional changes to other > places that refer to , > > diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt > index 67d48e688..ba4a545bf 100644 > --- a/Documentation/git-rebase.txt > +++ b/Documentation/git-re

Re: [PATCH v2 0/3] rebase: give precise error message

2017-11-28 Thread Kaartic Sivaraam
On Tue, 2017-11-28 at 11:25 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > 1. "git rebase " does nothing > > Not limited to "rebase", you do not muck with remote-tracking branch > in your local repository, so it would be a bug if the above updated > where the remote-tracking bran

Re: [PATCH v2 0/3] rebase: give precise error message

2017-11-27 Thread Junio C Hamano
Kaartic Sivaraam writes: > 1. "git rebase " does nothing Not limited to "rebase", you do not muck with remote-tracking branch in your local repository, so it would be a bug if the above updated where the remote-tracking branch points at. The form of "git rebase" with one extra argument (i.e. n

[PATCH v2 0/3] rebase: give precise error message

2017-11-27 Thread Kaartic Sivaraam
Junio C Hamano writes: > Perhaps time to learn "git symbolic-ref HEAD" and use it instead of > depending on the name? Good point. Helped remove the assumption that there's no branch named HEAD. (and indirectly led to 2 additional patches and the 3 questions found below ;-) This started as a sma