Re: [PATCH v2 0/3] allow checkout and branch to create branches on a merge base

2019-04-26 Thread Junio C Hamano
Denton Liu writes: > Out of respect for your time as the maintainer (since you have a lot of > topics to deal with), how do you prefer small fixups be submitted? > > * A complete reroll of the whole series > * A replacement for one patch in the series > * A follow-up email with an "oops, please c

Re: [PATCH v2 0/3] allow checkout and branch to create branches on a merge base

2019-04-26 Thread Denton Liu
On Fri, Apr 26, 2019 at 04:40:24PM -0700, Denton Liu wrote: [snip] > I'm going send a reroll to update the documentation to mention "..." in > and, while I'm at it, I'll do the squash. Actually, I have a quick question for you: Out of respect for your time as the maintainer (since you have a l

Re: [PATCH v2 0/3] allow checkout and branch to create branches on a merge base

2019-04-26 Thread Denton Liu
On Sat, Apr 27, 2019 at 08:07:34AM +0900, Junio C Hamano wrote: > Denton Liu writes: > > > Thanks for your comments, Eric and Junio. > > > > Eric, I've combined the `test_when_finished` calls together so that the > > statements within appear in a more "logical" order. > > > > Junio, I've taken yo

Re: [PATCH v2 0/3] allow checkout and branch to create branches on a merge base

2019-04-26 Thread Junio C Hamano
Denton Liu writes: > Thanks for your comments, Eric and Junio. > > Eric, I've combined the `test_when_finished` calls together so that the > statements within appear in a more "logical" order. > > Junio, I've taken your suggestion and moved the change into > `create_branch`. Initially, I didn't w

[PATCH v2 0/3] allow checkout and branch to create branches on a merge base

2019-04-26 Thread Denton Liu
Thanks for your comments, Eric and Junio. Eric, I've combined the `test_when_finished` calls together so that the statements within appear in a more "logical" order. Junio, I've taken your suggestion and moved the change into `create_branch`. Initially, I didn't want to do this because I didn't w